mzzz-zzm commented on PR #983: URL: https://github.com/apache/iceberg-go/pull/983#issuecomment-4386003693
All points addressed. Summary of what changed: - **`partitionTupleKey` removed** — replaced by `anyToLiteral` (type switch) + `eqDeletePartitionsToFilter` (builds typed `OR(AND(EqualTo(...)))` filter) - **Routes through `validateAddedDataFilesMatchingFilter`** — spec evolution, manifest pruning, and type-aware evaluation all handled by the existing path - **Unpartitioned fallback hoisted to caller** — `RowDelta.validate` checks `NumFields() == 0` and passes `AlwaysTrue` directly - **Unrelated changes removed** — `catalog/rest/rest.go` and the `newConflictContext` empty-base change are both reverted to match `origin/main` - **10 tests added** — 6 end-to-end `RowDelta.validate` regression tests (#978 reproducer, same/different partition, UUID type safety, unpartitioned fallback, spec-evolution cross-spec conflict detection) + 4 unit tests for `anyToLiteral` and `validateNoConflictingDataFilesInPartitions` helpers - **Both `RowDelta` struct doc comment and `validate` function doc updated** to describe the partition-scoped behavior (struct-level comment previously still said "AlwaysTrue") - **All 19 test packages pass** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
