kevinjqliu commented on code in PR #16107:
URL: https://github.com/apache/iceberg/pull/16107#discussion_r3196722646
##########
gcp-bundle/build.gradle:
##########
@@ -23,18 +23,13 @@ project(":iceberg-gcp-bundle") {
tasks.jar.dependsOn tasks.shadowJar
- configurations {
- implementation {
- exclude group: 'com.google.code.findbugs', module: 'jsr305'
- }
- }
-
dependencies {
implementation platform(libs.google.libraries.bom)
implementation "com.google.cloud:google-cloud-storage"
implementation "com.google.cloud:google-cloud-bigquery"
implementation "com.google.cloud:google-cloud-core"
implementation "com.google.cloud:google-cloud-kms"
+ implementation "com.google.cloud:google-cloud-monitoring"
Review Comment:
looks like it was already pulled transitively and already part of
runtime-deps.txt, hence no diff here
https://github.com/apache/iceberg/blob/b7ef9f1fa82ac1bcf57359e746128a706b2d232e/gcp-bundle/runtime-deps.txt#L44
👍
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -73,6 +73,18 @@ public class GCPProperties implements Serializable {
/** Controls whether analytics core library is enabled or not. Defaults to
false. */
public static final String GCS_ANALYTICS_CORE_ENABLED =
"gcs.analytics-core.enabled";
+ /**
+ * Controls the Google Cloud project ID used for Google Cloud Monitoring
metrics. Defaults to the
+ * GCS project ID.
+ */
+ public static final String GCP_MONITORING_PROJECT_ID =
"gcp.monitoring.project-id";
+
+ /** Controls the metric prefix used for Google Cloud Monitoring metrics. */
+ public static final String GCP_MONITORING_METRIC_PREFIX =
"gcp.monitoring.metric-prefix";
+
+ /** Default metric prefix for Google Cloud Monitoring metrics. */
+ public static final String GCP_MONITORING_METRIC_PREFIX_DEFAULT =
"custom.googleapis.com/iceberg";
+
Review Comment:
nit: gcs vs gcp. i see we use `gcs.` prefix in all the other places. If we
are starting to use `gcp.`, we should document it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
