nssalian commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r3197194350


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java:
##########
@@ -500,6 +503,27 @@ protected int resolveColumnIndex(Void engineSchema, String 
columnName) {
       assertThat(typedValue.containsField("b")).isTrue();
     }
 
+    // Verify data is in typed columns by reading raw Parquet groups
+    try (ParquetReader<Group> rawReader =
+        ParquetReader.builder(
+                new GroupReadSupport(), new 
org.apache.hadoop.fs.Path(outputFile.location()))

Review Comment:
   I saw that in another test too 
[here](https://github.com/apache/iceberg/blob/b7ef9f1fa82ac1bcf57359e746128a706b2d232e/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java#L159)
  and the `TestParquetDataWriter` has `import java.nio.file.Path` so it would 
conflict. I'm not sure if there is a better way. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to