rdblue commented on code in PR #14234: URL: https://github.com/apache/iceberg/pull/14234#discussion_r3197655590
########## format/spec.md: ########## @@ -683,6 +683,13 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access to a deletion vector. For deletion vectors, these values are required and must exactly match the `offset` and `length` stored in the Puffin footer for the deletion vector blob. 6. The following field ids are reserved on `data_file`: 141. +###### File-level column statistics + +Per-column metrics used for filtering and planning are stored at **file** granularity on the `data_file` struct. Review Comment: I think that the section heading and this line should be removed. The next two lines should be moved above notes and combined with the description of "column metrics maps", which are the v3 and earlier solution. What we need to say just after the table is: * Column stats are stored as maps in v3 and earlier (what you have on line 689) * Column stats are stored as structs in v4 and later (what you have on line 690) * The statement about delete file metrics covering the deleted rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
