CTTY commented on PR #2395:
URL: https://github.com/apache/iceberg-rust/pull/2395#issuecomment-4392912969
After a second thought, I think we should just remove the assertion.
Due to clock skew, it doesn't make sense to use `last_updated_ms` to confirm
whether the table has been updated. A newer `last_updated_ms` can technically
be smaller than the previous ts.
The existing test uses `metadata_location` and `snapshot_log` to confirm the
table is updated, and it is already sufficient:
```
assert_ne!(table.metadata_location(),
updated_table.metadata_location());
assert!(
table.metadata().metadata_log().len() <
updated_table.metadata().metadata_log().len()
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
