tanmayrauth commented on PR #1020: URL: https://github.com/apache/iceberg-go/pull/1020#issuecomment-4393005677
The spec's write.metadata.compression-codec formally lists only gzip and none, but both PyIceberg and the Java implementation already support zstd as an extension I've followed the same pattern. For the generic helper point, I've refactored it: extracted a newDecompressor(r io.Reader, codec string) (io.ReadCloser, error) that handles both codecs behind a unified io.ReadCloser interface, so adding a future codec is just one case in a switch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
