TwinklerG commented on PR #2120: URL: https://github.com/apache/iceberg-rust/pull/2120#issuecomment-4395981088
I'm not quite sure whether the current implementation is a good one? Perhaps some methods could be added at the `SchemaBuilder` or something similar to make atomic changes at the Schema level for each operation instead of collect all delta changes and apply them finally similar to Java Implementations(I mean something such as `rebuild_fields` which needs collected changes like `additions_by_parent` and `delete_ids`) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
