zhjwpku commented on code in PR #641:
URL: https://github.com/apache/iceberg-cpp/pull/641#discussion_r3201619207
##########
src/iceberg/file_io.h:
##########
@@ -50,21 +138,14 @@ class ICEBERG_EXPORT FileIO {
/// \return The content of the file if the read succeeded, an error code if
the read
/// failed.
virtual Result<std::string> ReadFile(const std::string& file_location,
- std::optional<size_t> length) {
- // We provide a default implementation to avoid Windows linker error
LNK2019.
- return NotImplemented("ReadFile not implemented");
- }
+ std::optional<size_t> length);
Review Comment:
Can we just use int64_t for the length? Not a strong opinion, just bring
this on table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
