zoobst commented on issue #958: URL: https://github.com/apache/iceberg-go/issues/958#issuecomment-4399284209
@Hashcode-Ankit @laskoviymishka — thanks for picking this up. On the Glue catalog HTTP config question (the [glue.go#L94](https://github.com/apache/iceberg-go/blob/bb1b1489c13d20ddc15bf325ae991520475443c8/catalog/glue/glue.go#L94) line): the injection path already works cleanly today. `glue.NewCatalog(WithAwsConfig(awsCfg))` stores the config, then [glue.go#L277](https://github.com/apache/iceberg-go/blob/main/catalog/glue/glue.go#L277) does `utils.WithAwsConfig(ctx, c.awsCfg)`, and `createS3Bucket` reads it via `utils.GetAwsConfig(ctx)`. So a user can do: ```go import awshttp "github.com/aws/aws-sdk-go-v2/aws/transport/http" hc := awshttp.NewBuildableClient().WithTransportOptions(func(t *http.Transport) { t.MaxIdleConnsPerHost = 256 t.MaxConnsPerHost = 256 t.IdleConnTimeout = 90 * time.Second }) awsCfg.HTTPClient = hc cat := glue.NewCatalog(glue.WithAwsConfig(awsCfg)) ``` ...and the tuned client propagates through to gocloud's S3 reads. We've verified this works in testing; its how we worked around the issue. So the mechanism is already there; what's missing is (a) the documentation pointing users at it, and (b) higher defaults for users who don't inject anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
