geruh commented on code in PR #3288:
URL: https://github.com/apache/iceberg-python/pull/3288#discussion_r3204234422
##########
tests/catalog/test_rest.py:
##########
@@ -2122,6 +2123,77 @@ def test_table_identifier_in_commit_table_request(
)
+def test_register_view_200(rest_mock: Mocker, example_view_metadata_rest_json:
dict[str, Any]) -> None:
+ rest_mock.head(
+ f"{TEST_URI}v1/namespaces/default/tables/registered_view",
+ status_code=404,
+ request_headers=TEST_HEADERS,
+ )
+ rest_mock.post(
+ f"{TEST_URI}v1/namespaces/default/register-view",
+ json=example_view_metadata_rest_json,
+ status_code=200,
+ request_headers=TEST_HEADERS,
+ )
+
+ catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+ actual = catalog.register_view(
+ identifier=("default", "registered_view"),
metadata_location="s3://warehouse/database/view/metadata.json"
+ )
+ expected = View(
+ identifier=("default", "registered_view"),
+ metadata=ViewMetadata(**example_view_metadata_rest_json["metadata"]),
+ )
+ assert actual == expected
+
+
+def test_register_view_409_view(rest_mock: Mocker) -> None:
+ rest_mock.head(
+ f"{TEST_URI}v1/namespaces/default/tables/registered_view",
+ status_code=404,
+ request_headers=TEST_HEADERS,
+ )
+ rest_mock.post(
+ f"{TEST_URI}v1/namespaces/default/register-view",
+ json={
+ "error": {
+ "message": "View already exists: default.view in warehouse
8bcb0838-50fc-472d-9ddb-8feb89ef5f1e",
+ "type": "AlreadyExistsException",
+ "code": 409,
+ }
+ },
+ status_code=409,
+ request_headers=TEST_HEADERS,
+ )
+
+ catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+ with pytest.raises(ViewAlreadyExistsError) as e:
+ catalog.register_view(
+ identifier=("default", "registered_view"),
metadata_location="s3://warehouse/database/view/metadata.json"
+ )
+ assert "View already exists" in str(e.value)
+
+
+def test_register_view_409_table(rest_mock: Mocker) -> None:
+ rest_mock.head(
+ f"{TEST_URI}v1/namespaces/default/tables/registered_view",
+ status_code=200,
+ request_headers=TEST_HEADERS,
+ )
+ rest_mock.post(
Review Comment:
non blocking nit: we don't need this code block since we hit on
`self.table_exists()` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
