mukund-thakur opened a new issue, #16248:
URL: https://github.com/apache/iceberg/issues/16248

   ### Feature Request / Improvement
   
   max-file-group-size-bytes and MAX_FILE_GROUP_SIZE_BYTES_DEFAULT are present 
in two places thus can lead to confusion. 
   
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java#L76
   
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java#L106
   
   I suggest we keep the size based configs only in 
SizeBasedFileRewritePlanner. Anyway MAX_FILE_GROUP_SIZE_BYTES_DEFAULT from 
RewriteDataFiles  is not unused. 
   
   
   ### Query engine
   
   None
   
   ### Willingness to contribute
   
   - [ ] I can contribute this improvement/feature independently
   - [ ] I would be willing to contribute this improvement/feature with 
guidance from the Iceberg community
   - [ ] I cannot contribute this improvement/feature at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to