XuQianJin-Stars commented on pull request #1240: URL: https://github.com/apache/iceberg/pull/1240#issuecomment-740014725
> > If it is set to false here, there will be a situation where the hdfs file directory will not be deleted when the flink sql client is deleting the database. What is the reason for this setting to false? > > @XuQianJin-Stars: This PR has not changed the behavior of dropping namespaces. The highlighted code was added with #919 > > Independently of this IMO the best place for these questions would be the dev list, but I guess that we wanted to be conservative about dropping a namespace to prevent accidentally removing wrong directories and with them important data. Thank you, I understand what you mean, do we need to expose the parameter option to the user, let the user decide whether to really delete the database? And the default option is not to delete data. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
