rdblue commented on a change in pull request #1870:
URL: https://github.com/apache/iceberg/pull/1870#discussion_r537727184



##########
File path: LICENSE
##########
@@ -289,3 +289,15 @@ Copyright: 2011-2018 The Apache Software Foundation
 Home page: http://hive.apache.org/
 License: http://www.apache.org/licenses/LICENSE-2.0
 
+--------------------------------------------------------------------------------
+
+This software contains unmodified binary redistributions for
+H2 database engine (https://h2database.com/),
+which is dual licensed and available under the MPL 2.0
+(Mozilla Public License) or under the EPL 1.0 (Eclipse Public License).
+An original copy of the license agreement can be found at:
+https://h2database.com/html/license.html
+
+Copyright: Copyright 2004-2020 H2 Group. Multiple-Licensed under the MPL 2.0, 
and the EPL 1.0
+Home page: https://h2database.org/
+License: https://www.h2database.com/html/license.html

Review comment:
       This doesn't need to be added unless Iceberg actually contains something 
that is copyrighted by the H2 database engine. The LICENSE is updated if 
Iceberg adds code based on another project or if Iceberg bundles another 
project into an Iceberg artifact (like the runtime Jars). Since this is just 
used as a test dependency, there is no need.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to