timactive commented on PR #2391:
URL: https://github.com/apache/iceberg-rust/pull/2391#issuecomment-4407074045
+1
```markdown — reproduced on a 484k-row table via fast_append. Without this
fix, `total-records` of the new snapshot was set to `added-records`
(=2 for a 2-row delta) instead of `parent.total + added` (=484065).
With the patch applied locally, the snapshot summary correctly
reports the cumulative and downstream consumers reading metadata.json
directly (iceberg-java in our case) see the right value on the next
commit. 36/36 snapshot tests stay green.
Edge case for the docs / future follow-up: tables with history
already corrupted by the buggy version will keep propagating wrong
totals because parent.total-records is read as-is. In practice
re-bootstrapping unblocks; a chain-walk recompute could self-heal
if needed, but it's not warranted for this PR. Thanks for the fix!```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
