zeroshade commented on code in PR #1040:
URL: https://github.com/apache/iceberg-go/pull/1040#discussion_r3210997508
##########
table/arrow_utils.go:
##########
@@ -1607,6 +1607,15 @@ func positionDeleteRecordsToDataFiles(ctx
context.Context, rootLocation string,
}
}
+ // V3 and later prefer deletion vectors over Parquet position-delete
files;
+ // warn so users migrate when DV-write support lands. The check is `>=
3`
+ // rather than `== 3` so the warning carries forward to v4+ without
churn.
+ // See apache/iceberg#12048.
+ if latestMetadata.Version() >= 3 {
+ slog.Warn("writing Parquet position-delete file on a v3 table;
use deletion vectors instead",
Review Comment:
maybe change the wording to be "prefer deletion vectors" rather than "use
deletion vectors"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
