emkornfield commented on code in PR #16258:
URL: https://github.com/apache/iceberg/pull/16258#discussion_r3211588919
##########
gcp/src/test/java/org/apache/iceberg/gcp/gcs/TestPrefixedStorage.java:
##########
@@ -115,17 +115,27 @@ public void impersonationPropertiesWithDefaults() {
.isEqualTo(GCPProperties.GCS_IMPERSONATE_LIFETIME_SECONDS_DEFAULT);
}
+ @Test
+ public void gcsFileSystemDisabledByDefault() {
+ Map<String, String> properties =
ImmutableMap.of(GCPProperties.GCS_PROJECT_ID, "myProject");
+ PrefixedStorage storage = new PrefixedStorage("gs://bucket", properties,
null);
+
+ assertThat(storage.gcsFileSystem()).isNull();
+ }
+
@Test
public void gcsFileSystem() {
Map<String, String> properties =
- ImmutableMap.of(
- GCPProperties.GCS_PROJECT_ID, "myProject",
- GCPProperties.GCS_USER_PROJECT, "userProject",
- GCPProperties.GCS_CLIENT_LIB_TOKEN, "gccl",
- GCPProperties.GCS_SERVICE_HOST, "example.com",
- GCPProperties.GCS_DECRYPTION_KEY, "decryptionKey",
- GCPProperties.GCS_ENCRYPTION_KEY, "encryptionKey",
- GCPProperties.GCS_CHANNEL_READ_CHUNK_SIZE, "1024");
+ ImmutableMap.<String, String>builder()
Review Comment:
I guess adding `GCPProperties.GCS_ANALYTICS_CORE_ENABLED, "true")` might
have caused this to exceed the largest overload of `ImmutableMap.of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
