dentiny opened a new issue, #2419: URL: https://github.com/apache/iceberg-rust/issues/2419
### Apache Iceberg Rust version None ### Describe the bug Hi team, [spec](https://iceberg.apache.org/puffin-spec/#footer-payload) requires puffin footer to be either uncompressed or LZ4 compressed. But currently we [don't implement](https://github.com/apache/iceberg-rust/blob/4f21e503afc5363c10fafac917f0febe136c464e/crates/iceberg/src/compression.rs#L121-L124) lz4, which means the compression flag is incorrect. ### To Reproduce Example to reproduce ```rust #[tokio::test] async fn test_compress_footer_fails_because_lz4_is_unsupported() { let temp_dir = TempDir::new().unwrap(); let file_io = FileIO::new_with_fs(); let path = temp_dir.path().join("compressed_footer.bin"); let output_file = file_io.new_output(path.to_str().unwrap()).unwrap(); // compress_footer=true sets the footer codec to LZ4, which is unimplemented. let writer = PuffinWriter::new(&output_file, HashMap::new(), /*compress_footer=*/true) .await .unwrap(); writer.close().await.unwrap(); } ``` Error message ```sh thread 'puffin::writer::tests::test_compress_footer_fails_because_lz4_is_unsupported' (400849) panicked at crates/iceberg/src/puffin/writer.rs:350:30: called `Result::unwrap()` on an `Err` value: FeatureUnsupported => LZ4 compression is not supported currently note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: puffin::writer::tests::test_compress_footer_fails_because_lz4_is_unsupported ``` ### Expected behavior When compression option specified, footer payload should be compressed and written without issue. ### Willingness to contribute None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
