dentiny commented on code in PR #1122:
URL: https://github.com/apache/iceberg-rust/pull/1122#discussion_r3212593432
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -55,6 +55,7 @@ pub struct SnapshotSummaryCollector {
partition_metrics: HashMap<String, UpdateMetrics>,
max_changed_partitions_for_summaries: u64,
properties: HashMap<String, String>,
+ trust_partition_metrics: bool,
Review Comment:
curious how do we plan to use `trust_partition_metrics`?
- It's by default false and never set to true anywhere
- It's of private visibility which cannot be set true outside
- It's not taking any affect in `build()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
