aihuaxu commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3215150246
##########
core/src/test/java/org/apache/iceberg/TestRowLineageAssignment.java:
##########
@@ -781,6 +782,22 @@ public void
testUpgradeAssignmentWithManifestCompaction(@TempDir File altLocatio
FILE_C.recordCount() + FILE_B.recordCount());
}
+ @Test
+ public void testRewritePreservesExistingFileFirstRowIds() {
Review Comment:
Understand the logic a little bit: seems during merge or filter manifest, we
may have null first_row_id at manifest while the existing file already has
row_id which should be kept.
Tried for filtering case and the fix works. Maybe we can add the test
coverage for filtering as well.
// apply a row filter so the read happens through the "filtered manifest"
path
reader.filterRows(Expressions.greaterThan("id", 0));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
