laskoviymishka opened a new issue, #1057: URL: https://github.com/apache/iceberg-go/issues/1057
Parent: #589, follows #1049. `puffin.Writer.AddBlob` already enforces the spec invariants that `snapshot-id` and `sequence-number` on a `deletion-vector-v1` blob must both be `-1`. The other spec-mandated DV invariants — that `properties` carry `cardinality` and `referenced-data-file` — are not enforced. A Go DV writer that forgets to attach either can produce non-conformant blobs the reader silently accepts via the spec-deviation tolerance path landed in #1049. Extend the existing DV branch in `AddBlob`: when `input.Type == BlobTypeDeletionVector`, require `input.Properties["cardinality"] != ""` and `input.Properties["referenced-data-file"] != ""`. Surface a clear error for each missing property. A couple of unit subtests in `puffin_test.go`'s existing DV-error coverage close the loop. Symmetric with the reader-side check landed in #1048 (`validateBlobs`). Closes the gap that prompted the reader-side `slog.Warn` fallback in #1049 — once writers can't omit the property, the warning path stops being reachable from in-tree writes and only fires for cross-impl reads of files written by other tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
