anuragmantri commented on code in PR #16285: URL: https://github.com/apache/iceberg/pull/16285#discussion_r3220598075
########## core/src/main/java/org/apache/iceberg/ColumnFileInfo.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import org.apache.iceberg.types.Types; + +/** Information about a column file. */ +interface ColumnFileInfo { + Types.NestedField FIELD_IDS = + Types.NestedField.required( + 159, + "field_ids", + Types.ListType.ofRequired(160, Types.IntegerType.get()), + "Field IDs this column file contains"); + Types.NestedField LOCATION = + Types.NestedField.required( + 161, "location", Types.StringType.get(), "Location of the column file"); + Types.NestedField FILE_SIZE_IN_BYTES = + Types.NestedField.required( + 162, "file_size_in_bytes", Types.LongType.get(), "Total column file size in bytes"); + Types.NestedField SEQUENCE_NUMBER = + Types.NestedField.optional( + 163, "sequence_number", Types.LongType.get(), "Sequence number of the column file"); + + static Types.StructType schema() { + return Types.StructType.of(FIELD_IDS, LOCATION, FILE_SIZE_IN_BYTES, SEQUENCE_NUMBER); + } + + /** Returns the field IDs contained in this column file. */ + List<Integer> fieldIds(); + + /** Returns the location of the column file. */ + String location(); + + /** Returns the total size of the column file in bytes. */ + long fileSizeInBytes(); + + /** Returns the sequence number of the column file. */ + long sequenceNumber(); Review Comment: If we decide to keep this, it should return `Long` since it is an optional field. ########## core/src/main/java/org/apache/iceberg/TrackedFileStruct.java: ########## @@ -205,6 +212,11 @@ public List<Integer> equalityIds() { return equalityIds != null ? ArrayUtil.toUnmodifiableIntList(equalityIds) : null; } + @Override + public List<ColumnFileInfo> columnFiles() { + return columnFiles; + } Review Comment: Can we use unmodifiable collections like the test of the tracking struct? ``` @Override public List<ColumnFileInfo> columnFiles() { return columnFiles != null ? Collections.unmodifiableList(columnFiles) : null; } ``` ########## core/src/main/java/org/apache/iceberg/ColumnFileInfo.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import org.apache.iceberg.types.Types; + +/** Information about a column file. */ +interface ColumnFileInfo { Review Comment: Can we always assume the column file uses the same file_format as base file? If not, can we explicitly add `file_format` here? ########## core/src/main/java/org/apache/iceberg/ColumnFileInfo.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import org.apache.iceberg.types.Types; + +/** Information about a column file. */ +interface ColumnFileInfo { + Types.NestedField FIELD_IDS = + Types.NestedField.required( + 159, + "field_ids", + Types.ListType.ofRequired(160, Types.IntegerType.get()), + "Field IDs this column file contains"); + Types.NestedField LOCATION = + Types.NestedField.required( + 161, "location", Types.StringType.get(), "Location of the column file"); + Types.NestedField FILE_SIZE_IN_BYTES = + Types.NestedField.required( + 162, "file_size_in_bytes", Types.LongType.get(), "Total column file size in bytes"); Review Comment: Should we wait for finalizing the spec? I will create a spec PR when it has been finalized and then we can continue this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
