rdblue commented on a change in pull request #1842:
URL: https://github.com/apache/iceberg/pull/1842#discussion_r537861913
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTypeConverter.java
##########
@@ -30,7 +37,52 @@ private HiveTypeConverter() {
}
- public static String convert(Type type) {
+ /**
+ * Converts the Iceberg schema to a Hive schema.
+ * @param schema The original Iceberg schema to convert
+ * @return The Hive column list generated from the Iceberg schema
+ */
+ public static List<FieldSchema> hiveSchema(Schema schema) {
Review comment:
Yes, sounds like you're heading in the direction I suggested. I'm
flexible on how we get there and would defer to your judgement on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
