nssalian commented on PR #932: URL: https://github.com/apache/iceberg-go/pull/932#issuecomment-4426230650
Thank you for the reviews. Fixed the two things Andrei flagged: substrait nil panic (VisitVariant returns BinaryType placeholder + test) and the fragile !hasStats check in colMapping (now uses a precomputed variant field ID set from the schema, with ancestor walk for variant sub-columns). Applied Matt's `literal` feedback with type alias pattern, String() delegates to variant.Value, Equals compares metadata + value bytes, TODO on To() for future type coercion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
