visit2rahul commented on issue #13580:
URL: https://github.com/apache/iceberg/issues/13580#issuecomment-4431885612
Quick context for reviewers — this issue has been attempted twice before:
- #13940 (@Narendra9793) — closed unmerged
- #14142 (@aheev) — closed unmerged after extended inactivity
Both are now closed, so this is the only active PR for #13580.
@nastra — your earlier review on #14142 laid out four concrete requirements.
Mapping each to this PR for ease of review:
1. ✅ **Request/response classes in their respective packages**
-
`core/src/main/java/org/apache/iceberg/rest/requests/QueryEventsRequest.java`
-
`core/src/main/java/org/apache/iceberg/rest/responses/QueryEventsResponse.java`
2. ✅ **Separate JSON parser classes with tests**
- Parsers: `QueryEventsRequestParser`, `QueryEventsResponseParser`,
`EventParser`, `CatalogOperationParser`
- Tests: `TestQueryEventsRequestParser`, `TestQueryEventsResponseParser`,
`TestEventParser`
3. ✅ **Parsers registered in `RESTSerializers`**
- `core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java`
updated
4. ✅ **All new types under the `rest` package in `iceberg-core`**
- Everything sits under
`core/src/main/java/org/apache/iceberg/rest/{events,requests,responses}/`
Followed the parser patterns from your referenced commits (1cb88a64 and
f19643a9).
@c-thiel — tagging you as the proposal author; happy to incorporate any
feedback on the operation-type modeling or event semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
