rchowell commented on code in PR #2311: URL: https://github.com/apache/iceberg-rust/pull/2311#discussion_r3236351946
########## crates/catalog/rest/src/catalog.rs: ########## @@ -52,6 +53,12 @@ pub const REST_CATALOG_PROP_URI: &str = "uri"; pub const REST_CATALOG_PROP_WAREHOUSE: &str = "warehouse"; /// Disable header redaction in error logs (defaults to false for security) pub const REST_CATALOG_PROP_DISABLE_HEADER_REDACTION: &str = "disable-header-redaction"; +/// Enable AWS SigV4 signing for REST catalog requests +pub const REST_CATALOG_PROP_SIGV4_ENABLED: &str = "rest.sigv4-enabled"; +/// The AWS service name to use for SigV4 signing (e.g. "s3", "execute-api") +pub const REST_CATALOG_PROP_SIGNING_NAME: &str = "rest.signing-name"; +/// The AWS region to use for SigV4 signing (e.g. "us-east-1") +pub const REST_CATALOG_PROP_SIGNING_REGION: &str = "rest.signing-region"; Review Comment: I'll move them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
