laskoviymishka commented on PR #1055: URL: https://github.com/apache/iceberg-go/pull/1055#issuecomment-4444721153
Yep, spec mandates -1 for `deletion-vector-v1`. A DV is bound to a data file (via `referenced-data-file`), not to a snapshot — its applicable seq number comes from the v3 manifest entry, not the blob. Other blob types like theta sketches do use those fields (they're per-snapshot stats), but for DVs Java's `BaseDVFileWriter` writes -1/-1 and `DeleteFileIndex` reads the seq number off the manifest. Forcing -1 keeps readers from accidentally picking up the wrong field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
