tanmayrauth commented on PR #1071:
URL: https://github.com/apache/iceberg-go/pull/1071#issuecomment-4445506229
Thanks for the thorough review! I've made the changes:
- Rollback now goes through a new Transaction.RollbackToSnapshot method
that bakes in both the CAS (AssertRefSnapshotID) and ancestry check
(IsAncestorOf), so it gets the OCC retry loop from Transaction.Commit for free.
Also kept the early ancestry check in the CLI for a clearer user-facing error
before hitting the confirmation prompt.
- Moved the version guard after the dry-run branch so upgrade TABLE 1
--dry-run produces the no-op preview as expected.
- Fixed receivers, pipe error handling, and pterm cleanup as suggested.
- Added end-to-end tests with a panicking fake catalog covering
dry-run-no-commit, already-at-version dry-run, non-TTY rejection, and
non-ancestor rejection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
