tanmayrauth commented on PR #1068:
URL: https://github.com/apache/iceberg-go/pull/1068#issuecomment-4445602064
I've addressed the below points:
1. Create-only semantics — Added pre-flight check against meta.Refs() for
a clear local error, plus AssertRefSnapshotID(name, nil) in the requirements
slice for server-side race protection. Matches Java/PyIceberg behavior.
2. Confirmation gate — Added --yes to both BranchCreateCmd and
TagCreateCmd, with confirmAction called before CommitTable.
3. Error style — Fixed to "failed to create branch" / "failed to create
tag".
4. Snapshot ID validation — resolveSnapshotID now calls meta.SnapshotByID
and errors with snapshot %d not found when the explicit ID doesn't exist.
5. Retention in JSON result — RefCreatedResult now includes
max_ref_age_ms, max_snapshot_age_ms, min_snapshots_to_keep (with omitempty).
6. Test fixes — os.Pipe() error is checked with require.NoError, pterm
global state restored via t.Cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
