tanmayrauth commented on PR #1069:
URL: https://github.com/apache/iceberg-go/pull/1069#issuecomment-4445690768
Adressed the below things:
- Switched to ErrInvalidMetadataFormatVersion — agreed that
ErrInvalidMetadata implies corruption
- Refactored to variadic ...v3FieldCheck so new fields are a one-line
addition
- Call sites now read aux.FormatVersion instead of literal 1/2
- Tests collapsed into a single table-driven subtest, added the
v3+encryption-keys positive case and the empty encryption-keys: [] boundary
case
On the strictness question : the spec explicitly scopes these fields to v3,
so my thinking was that surfacing the mismatch early (with a clear,
distinguishable error) helps consumers catch misconfigured metadata closer to
the source. In the v3→v2 downgrade scenario, ideally the downgrade tool would
strip v3 fields - silently accepting them downstream could mask that gap for
Go consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
