CTTY commented on code in PR #2308:
URL: https://github.com/apache/iceberg-rust/pull/2308#discussion_r3238656022
##########
crates/iceberg/src/table.rs:
##########
@@ -230,6 +244,15 @@ impl Table {
MetadataTable::new(self)
}
+ /// Returns a resolved [`Runtime`] for this table.
+ ///
+ /// If a runtime was set via [`TableBuilder::runtime`], it is returned.
+ /// Otherwise, this borrows the ambient tokio runtime via
+ /// [`Runtime::current`], which panics if called outside a tokio context.
+ pub(crate) fn runtime(&self) -> Runtime {
Review Comment:
This is a getter, not a setter. Or do you mean that we should not fallback
to the current runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
