talatuyarer commented on code in PR #16313:
URL: https://github.com/apache/iceberg/pull/16313#discussion_r3240031718
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -111,7 +112,10 @@ public FlinkCatalog(
long cacheExpirationIntervalMs) {
super(catalogName, defaultDatabase);
this.catalogLoader = catalogLoader;
- this.catalogProps = catalogProps;
+ this.catalogProps =
+ catalogProps.entrySet().stream()
+ .filter(e -> !GlobalConfiguration.isSensitive(e.getKey()))
+ .collect(ImmutableMap.toImmutableMap(Map.Entry::getKey,
Map.Entry::getValue));
Review Comment:
@pvary The `isSensitive` list doesn't cover all Iceberg configurations. For
example, the `credential` keyword used for REST catalog OAuth2 client
credentials or S3 access key was only added to Flink's list in a later release
than the one we're using. See
[https://github.com/apache/flink/blob/release-2.2.1/flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java#L49](https://github.com/apache/flink/blob/release-2.2.1/flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java#L49)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
