vishnuprakaz opened a new pull request, #3360: URL: https://github.com/apache/iceberg-python/pull/3360
Adds `@override` from `typing_extensions` to all concrete implementations of `Catalog`, `MetastoreCatalog`, `FileIO`, `InputFile`, and `OutputFile` so overridden base-class methods are explicit and can be verified by static type checkers. Uses `from typing_extensions import override` (same pattern already used for `Self` in `typedef.py`) instead of `from typing import override` which requires Python 3.12+ and would break the supported 3.10/3.11 versions. Closes #1310 # Rationale for this change `@typing.override` (PEP 698) makes it explicit which methods intentionally override a parent class method, helping static type checkers catch mistakes early. The previous attempt (#1312) and the currently open PR (#3359) both use `from typing import override` which only exists in Python 3.12+. This PR uses `typing_extensions` to support all versions from 3.10+. ## Are these changes tested? No new tests are needed — `@override` is a static analysis marker with zero runtime effect. `make lint` and `make test` (3625 passed) both pass cleanly. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
