happydave1 commented on code in PR #1045:
URL: https://github.com/apache/iceberg-go/pull/1045#discussion_r3241355606
##########
table/scanner.go:
##########
@@ -674,3 +690,79 @@ func (scan *Scan) ToArrowTable(ctx context.Context)
(arrow.Table, error) {
return array.NewTableFromRecords(schema, records), nil
}
+
+func schemaContainsMeta(schema *iceberg.Schema) bool {
+ if schema == nil {
+ return false
+ }
+
+ _, hasRowIdMeta := schema.FindFieldByID(iceberg.RowIDFieldID)
Review Comment:
Nice catch! I did not know that fields get reassembled whenever a schema
goes through `NewMetadata`!
I think the clean fix would be to just use `FindFieldByName` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
