igorbelianski-cyber commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r3242285387
########## format/view-spec.md: ########## @@ -190,92 +190,93 @@ The table identifier for the storage table that stores the precomputed results. ### Storage table metadata This section describes additional metadata for the storage table that supplements the regular table metadata and is required for materialized views. -The property "refresh-state" is set on the [snapshot summary](https://iceberg.apache.org/spec/#snapshots) property of a storage table snapshot to provide information about the state of the precomputed data. +The `refresh-state` property is set on the [snapshot summary](https://iceberg.apache.org/spec/#snapshots) property of a storage table snapshot to provide information about the state of the precomputed data. | Requirement | Field name | Description | |-------------|-----------------|-------------| | _optional_ | `refresh-state` | A [refresh state](#refresh-state) record stored as a JSON-encoded string | #### Freshness -A materialized view is "fresh" when the storage table adequately represents the result of the view query at the current state of its dependencies. -Since different systems define freshness differently, it is left to the consumer to evaluate freshness based on its own policy. +A materialized view is **fresh** when the storage table represents the result of the current view query (at the materialized view's current `view-version-id`) over the current state of its dependencies. Dependencies are determined by parsing the SQL: base Iceberg tables, Iceberg views (whose own dependencies are transitively dependencies of the materialized view), and intermediate materialized views (treated as their storage tables, with their own freshness established recursively from their `refresh-state`). Review Comment: s/transitively/transitive/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
