RussellSpitzer commented on code in PR #16330:
URL: https://github.com/apache/iceberg/pull/16330#discussion_r3242595016
##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -147,6 +147,22 @@ public interface RewriteDataFiles
*/
String OUTPUT_SPEC_ID = "output-spec-id";
+ /**
+ * If true, the rewrite also selects data files whose sort order id does not
match the table's
+ * current default sort order id, even when they are already optimally
sized. This enables
Review Comment:
I would remove the "usage" explanation here. Since I'm not quite sure this
is the right thing to do for a truly incremental sort compaction. The "sort"
within the file is probably not as important as the global sort imho.
That said I think the first line is probably all you need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
