rdblue commented on code in PR #16092:
URL: https://github.com/apache/iceberg/pull/16092#discussion_r3244856122
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -246,4 +266,78 @@ public String toString() {
.add("replaced_positions", replacedPositions == null ? "null" :
"(binary)")
.toString();
}
+
+ static class Builder {
+ private EntryStatus status = null;
+ private Long snapshotId = null;
+ private Long dataSequenceNumber = null;
+ private Long fileSequenceNumber = null;
+ private Long dvSnapshotId = null;
+ private Long firstRowId = null;
+ private byte[] deletedPositions = null;
+ private byte[] replacedPositions = null;
+
+ Builder status(EntryStatus entryStatus) {
+ this.status = entryStatus;
+ return this;
+ }
+
+ Builder snapshotId(Long id) {
+ this.snapshotId = id;
+ return this;
+ }
+
+ Builder dataSequenceNumber(Long sequenceNumber) {
+ this.dataSequenceNumber = sequenceNumber;
+ return this;
+ }
+
+ Builder fileSequenceNumber(Long sequenceNumber) {
+ this.fileSequenceNumber = sequenceNumber;
+ return this;
+ }
+
+ Builder dvSnapshotId(Long id) {
+ this.dvSnapshotId = id;
+ return this;
+ }
+
+ Builder firstRowId(Long rowId) {
+ this.firstRowId = rowId;
+ return this;
+ }
+
+ Builder deletedPositions(ByteBuffer positions) {
+ this.deletedPositions = positions != null ?
ByteBuffers.toByteArray(positions) : null;
+ return this;
+ }
+
+ Builder deletedPositions(byte[] positions) {
+ this.deletedPositions = positions;
+ return this;
+ }
+
+ Builder replacedPositions(ByteBuffer positions) {
Review Comment:
It seems to me that this is premature. We should know whether we are going
to use `ByteBuffer` or `byte[]` before making this decision right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
