CTTY commented on code in PR #16343:
URL: https://github.com/apache/iceberg/pull/16343#discussion_r3245016437
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -584,22 +584,31 @@ public Optional<LogicalTypeVisitorResult> visit(
@Override
public Optional<LogicalTypeVisitorResult> visit(
LogicalTypeAnnotation.IntLogicalTypeAnnotation intLogicalType) {
- FieldVector vector = arrowField.createVector(rootAlloc);
int bitWidth = intLogicalType.getBitWidth();
if (bitWidth == 8 || bitWidth == 16 || bitWidth == 32) {
- // Iceberg has no unsigned integer type. Reading UINT32 into a 32-bit
signed value would
- // silently produce negative results for inputs above
Integer.MAX_VALUE. UINT8 and UINT16
- // both fit losslessly in a signed int32 and are allowed, matching the
policy in
- // BaseParquetReaders for the non-vectorized path.
Review Comment:
why do we remove this comment? this still looks relevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
