wombatu-kun opened a new pull request, #16345: URL: https://github.com/apache/iceberg/pull/16345
## Summary Removes the unused `conf` field from `OrcFileAppender` (TODO in source). The tests in `TestTableProperties` are reworked to verify the configured ORC codec end-to-end via `OrcFile.createReader` instead of reflecting into the appender. The previous tests asserted on four property keys (`STRIPE_SIZE`, `BLOCK_SIZE`, `COMPRESS`, `COMPRESSION_STRATEGY`). All four are propagated by the same straight-line code in `ORC.WriteBuilder.build()` — four adjacent `OrcConf.XXX.set(conf, …)` calls with no branching. A passing end-to-end check on the codec therefore implicitly confirms the rest: there is no realistic regression where one of these property copies breaks while the others survive. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
