kevinjqliu commented on code in PR #16368:
URL: https://github.com/apache/iceberg/pull/16368#discussion_r3253322826
##########
site/mkdocs.yml:
##########
@@ -76,6 +76,11 @@ plugins:
'docs/nightly/amoro.md': 'integrations/amoro.md'
'docs/nightly/daft.md': 'integrations/daft.md'
'docs/nightly/risingwave.md': 'integrations/risingwave.md'
+ - exclude-search:
+ exclude:
+ - 'docs/latest/*'
+ - 'docs/1*/*'
+ exclude_unreferenced: true
Review Comment:
nit: this is unnecessary and will exclude blog posts and other pages.
i suggest removing it, we just want to exclude duplicate versions of the site
> To exclude all unreferenced files (markdown files not listed in mkdocs.yml
nav section), use exclude_unreferenced: true. Default false.
https://github.com/chrieke/mkdocs-exclude-search#configuration
```suggestion
```
##########
site/mkdocs.yml:
##########
@@ -76,6 +76,11 @@ plugins:
'docs/nightly/amoro.md': 'integrations/amoro.md'
'docs/nightly/daft.md': 'integrations/daft.md'
'docs/nightly/risingwave.md': 'integrations/risingwave.md'
+ - exclude-search:
+ exclude:
+ - 'docs/latest/*'
+ - 'docs/1*/*'
Review Comment:
```suggestion
- exclude-search:
# Index only docs/latest/* to avoid duplicate hits across versions.
exclude:
- 'docs/nightly*' # excludes nightly and its children
- 'docs/[0-9]*' # excludes docs/<x.y.z> and their children
```
- added a couple of comments
- changed to `docs/nightly*` to capture the parent page
- change d to `[0-9]` in case we ever bump to 2.x
i think we want to make a decision whether we want to index `latest` or
`nightly`. im leaning towards `latest` because thats the most recent official
release (what people are most likely running on prod)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
