yadavay-amzn commented on PR #16237: URL: https://github.com/apache/iceberg/pull/16237#issuecomment-4469514463
@laskoviymishka You are right -- the `CleanableFailure` approach was too permissive. Reverted to the simpler and safer design: - **Full commit failure**: rethrow everything (kills coordinator -> task FAILED) - **Partial commit failure** (timed-out cleanup): WARN + swallow (retry next cycle) This matches your original direction. CI is green now. PR description updated to match the code. On the test coverage point (coordinatorTest skipping the production CoordinatorThread path) -- agreed that an end-to-end test through CoordinatorThread + CommitterImpl would be stronger. Happy to add that in this PR or as a follow-up, whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
