aokolnychyi commented on a change in pull request #1890:
URL: https://github.com/apache/iceberg/pull/1890#discussion_r538783656
##########
File path:
spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCherrypickSnapshotProcedure.java
##########
@@ -171,18 +167,10 @@ public void testInvalidCherrypickSnapshotCases() {
AssertHelpers.assertThrows("Should reject calls without all required args",
AnalysisException.class, "Missing required parameters",
- () -> sql("CALL %s.system.cherrypick_snapshot('n', 't')",
catalogName));
+ () -> sql("CALL %s.system.cherrypick_snapshot('t')", catalogName));
AssertHelpers.assertThrows("Should reject calls with invalid arg types",
AnalysisException.class, "Wrong arg type for snapshot_id: cannot cast",
- () -> sql("CALL %s.system.cherrypick_snapshot('n', 't', 2.2)",
catalogName));
-
- AssertHelpers.assertThrows("Should reject empty namespace",
- IllegalArgumentException.class, "Namespace cannot be empty",
- () -> sql("CALL %s.system.cherrypick_snapshot('', 't', 1L)",
catalogName));
-
- AssertHelpers.assertThrows("Should reject empty table name",
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
