yyanyy commented on a change in pull request #1820:
URL: https://github.com/apache/iceberg/pull/1820#discussion_r538784327
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -60,7 +60,7 @@ public PartitionData copy() {
private String filePath = null;
private FileFormat format = null;
private PartitionData partitionData = null;
- private Long recordCount = null;
+ private long recordCount = -1L;
Review comment:
I mostly did this to simplify testing as I noticed `fileSizeInBytes`
which is also a `long` has the pattern of defaulting to -1, but I don't have
strong opinion either way. Will revert!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
