tanmayrauth commented on issue #1086:
URL: https://github.com/apache/iceberg-go/issues/1086#issuecomment-4472047552

   Agreed, we should relax and match the other clients.                         
                                                                                
                                                                         
                                                                                
                                                                                
                                                                            
     Iceberg tables get read/written by multiple clients in the same pipeline. 
If any tool leaves a stray v3 field in v2 metadata, Java/PyIceberg/Rust all 
read it fine. Go becomes the only client that hard-fails. That's a production 
outage for Go users with no actual data integrity issue (the fields sit unused 
on commonMetadata and are never exposed via sub-v3 accessors).                  
                                                                        
                     
     Catching our own writer leaking v3 fields into v2 is valuable, but that 
belongs in writer-side tests - not reader-side validation that penalizes every 
consumer.                                                                       
                     
     Plan:                                                                      
                                                                                
                                                                            
     - Remove rejectV3OnlyFields and the call sites in v1/v2 unmarshal paths.
     - Add a short comment noting we intentionally match the lenient behavior 
of other clients, linking this issue.                                           
                                                                              
                                                                                
                                   
     This also makes the generalized rejectFieldsBeyondVersion follow-up moot.  
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to