smaheshwar-pltr commented on code in PR #3364:
URL: https://github.com/apache/iceberg-python/pull/3364#discussion_r3260057095


##########
dev/provision.py:
##########
@@ -395,3 +395,37 @@
     )
     spark.sql(f"ALTER TABLE {catalog_name}.default.test_empty_scan_ordered_str 
WRITE ORDERED BY id")
     spark.sql(f"INSERT INTO {catalog_name}.default.test_empty_scan_ordered_str 
VALUES 'a', 'c'")
+
+    # Append scan fixture. Snapshots written:
+    #   0: append (1, 'a')
+    #   1: append (2, 'b')
+    #   2: append (3, 'c'), (4, 'b')
+    #   3: delete number=2
+    #   4: append (5, 'd', 100) -- on evolved schema
+    #   5: replace table -- lineage break
+    spark.sql(
+        f"""
+            CREATE OR REPLACE TABLE 
{catalog_name}.default.test_incremental_read (

Review Comment:
   Partitioned by `letter` so the per-snapshot file layout is deterministic 
across Spark versions, which lets the integration tests assert on exact 
`plan_files()` counts. `ALTER ADD COLUMN extra` is included so the 
schema-evolution-within-range test runs on the same fixture, and the closing 
`REPLACE TABLE` is for the disconnected-snapshots test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to