smaheshwar-pltr commented on code in PR #3380:
URL: https://github.com/apache/iceberg-python/pull/3380#discussion_r3262823164
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -187,6 +188,7 @@ def create_table(
)
database_name, table_name =
self.identifier_to_database_and_table(identifier)
+ _raise_if_view_exists(self, identifier)
Review Comment:
Java
[`DynamoDbCatalog`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java)
has no view support. Closest reference is
[`HiveCatalog.ViewAwareTableBuilder.create()`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L876-L882).
Runtime no-op.
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -313,6 +315,7 @@ def rename_table(self, from_identifier: str | Identifier,
to_identifier: str | I
"""
from_database_name, from_table_name =
self.identifier_to_database_and_table(from_identifier, NoSuchTableError)
to_database_name, to_table_name =
self.identifier_to_database_and_table(to_identifier)
+ _raise_if_view_exists(self, to_identifier)
Review Comment:
No Java DynamoDb analog. Hive reference:
[`HiveCatalog.renameTableOrView`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L367-L369).
Runtime no-op.
##########
pyiceberg/catalog/bigquery_metastore.py:
##########
@@ -134,6 +134,7 @@ def create_table(
schema: Schema = self._convert_schema_if_needed(schema) # type: ignore
dataset_name, table_name =
self.identifier_to_database_and_table(identifier)
+ _raise_if_view_exists(self, identifier)
Review Comment:
No iceberg-java BigQuery analog. Hive reference for the semantics:
[`HiveCatalog.ViewAwareTableBuilder.create()`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L876-L882).
Runtime no-op until BQ gains view support.
##########
pyiceberg/catalog/bigquery_metastore.py:
##########
@@ -295,6 +296,7 @@ def register_table(self, identifier: str | Identifier,
metadata_location: str, o
if overwrite:
raise NotImplementedError("`overwrite` isn't supported")
+ _raise_if_view_exists(self, identifier)
Review Comment:
No iceberg-java BigQuery analog. Hive reference:
[`HiveCatalog.registerTable`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L941-L943).
Runtime no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
