slfan1989 commented on code in PR #659:
URL: https://github.com/apache/iceberg-cpp/pull/659#discussion_r3263890120
##########
src/iceberg/file_io.h:
##########
@@ -151,9 +151,27 @@ class ICEBERG_EXPORT FileIO {
///
/// \param file_location The location of the file to delete.
/// \return void if the delete succeeded, an error code if the delete failed.
- virtual Status DeleteFile(const std::string& file_location) {
Review Comment:
I changed this only to avoid the unused parameter warning in the default
implementation, since `file_location` is not used when returning
`NotImplemented`.
I thought it was a small cleanup while touching this area, but I agree it is
not required for this PR. I can revert it if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
