raulcd commented on code in PR #656:
URL: https://github.com/apache/iceberg-cpp/pull/656#discussion_r3265400666
##########
src/iceberg/test/parquet_test.cc:
##########
@@ -124,6 +128,27 @@ void DoRoundtrip(std::shared_ptr<::arrow::Array> data,
std::shared_ptr<Schema> s
ASSERT_TRUE(out != nullptr) << "Reader.Next() returned no data";
}
+struct ParquetCodec {
+ std::string name;
+ ::arrow::Compression::type compression;
+};
+
+std::optional<ParquetCodec> UnavailableParquetCodec() {
Review Comment:
LGTM should this function return the list of unavailable codecs instead of
the first one? Otherwise I feel like the name could be slightly misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
