pvary commented on code in PR #16423:
URL: https://github.com/apache/iceberg/pull/16423#discussion_r3265887347
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java:
##########
@@ -243,6 +243,26 @@ public void testCreateTableLikeInFlinkCatalog() throws
TableNotExistException {
.containsEntry(FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY,
srcCatalogProps);
}
+ @TestTemplate
+ public void testCreateTableComment() {
+ // create table with comment
+ sql("CREATE TABLE tl(id BIGINT) COMMENT 'table comment' WITH
('param'='some value')");
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put("comment", "table comment");
+ properties.put("param", "some value");
+ assertThat(table("tl").properties()).containsAllEntriesOf(properties);
+
+ // update parameter
+ sql("ALTER TABLE tl SET('param'='new value')");
Review Comment:
These are different tests. They should have a different test method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
