Shekharrajak commented on code in PR #2423:
URL: https://github.com/apache/iceberg-rust/pull/2423#discussion_r3265933641
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -692,6 +692,16 @@ impl SchemaVisitor for ToArrowSchemaConverter {
}
}
}
+
+ fn variant(
+ &mut self,
+ _v: &crate::spec::VariantType,
+ ) -> crate::Result<ArrowSchemaOrFieldOrType> {
+ Err(crate::Error::new(
+ crate::ErrorKind::FeatureUnsupported,
+ "Arrow schema conversion for Variant is not yet implemented",
Review Comment:
We will work on this in follow up PRs
##########
crates/iceberg/src/arrow/value.rs:
##########
@@ -426,6 +426,13 @@ impl SchemaWithPartnerVisitor<ArrayRef> for
ArrowArrayToIcebergStructConverter {
}
}
}
+
+ fn variant(&mut self, _v: &VariantType, _partner: &ArrayRef) ->
Result<Vec<Option<Literal>>> {
+ Err(Error::new(
+ ErrorKind::FeatureUnsupported,
+ "Arrow value extraction for Variant is not yet implemented",
Review Comment:
We will work on this in follow up PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
