C-Loftus opened a new pull request, #1094: URL: https://github.com/apache/iceberg-go/pull/1094
- Add geospatial test fixtures that can be used for validating geospatial logic performs as expected. All fixtures come from the [parquet-testing](https://github.com/apache/parquet-testing/tree/master/data/geospatial) repository. I was previously unaware this repo existed but I think this is the right data to use since it prevents us from needing to write custom pyarrow code to generate them. - I put all generation logic in a shell script since it's a bit more succinct then a custom script in go and I don't imagine it will need to be run very often given the last update of that test data was over a year ago. - Note these fixtures use all the **native parquet geometry type** _not_ the geoarrow encoding. I am pretty sure this is what we want, but if I am misinterpreting something let me know. My understanding is that geoarrow is not used in the native parquet type (but from reading other PRs like it seems like geoarrow-go is being used for some of the parse logic, not the storage encoding?) There is more data here https://github.com/geoarrow/geoarrow-data if we need more, some of which is `_native.parquet` but since it does include a lot of geoparquet files with the geoarrow encoding, I did not use any of these. Closes #1090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
